]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
dateMenu: Remove custom aligning of time strings in the World Clocks
authorMaksym Hazevych <dpadar@protonmail.com>
Mon, 20 Jun 2022 14:43:09 +0000 (17:43 +0300)
committerMarge Bot <marge-bot@gnome.org>
Thu, 7 Jul 2022 12:40:30 +0000 (12:40 +0000)
Since now Glib uses tabular space for aligning numbers (merged in
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2698), there is no
more need for custom aligning.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5438

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2340>

js/ui/dateMenu.js

index f3cb006139e15ee26bec6d06fa92f4cbc2182c42..bd363f3232d3851d8bb9ce907620d77f66ed974e 100644 (file)
@@ -418,10 +418,7 @@ class WorldClocksSection extends St.Button {
                 x_expand: true,
             });
 
-            let time = new St.Label({
-                style_class: 'world-clocks-time',
-                x_align: Clutter.ActorAlign.END,
-            });
+            let time = new St.Label({ style_class: 'world-clocks-time' });
 
             const tz = new St.Label({
                 style_class: 'world-clocks-timezone',
@@ -487,25 +484,10 @@ class WorldClocksSection extends St.Button {
     }
 
     _updateTimeLabels() {
-        let differentLength = false;
-        let lastLength;
         for (let i = 0; i < this._locations.length; i++) {
             let l = this._locations[i];
             const now = GLib.DateTime.new_now(l.location.get_timezone());
-            const text = Util.formatTime(now, { timeOnly: true });
-            l.timeLabel.text = text;
-
-            if (differentLength)
-                continue;
-            if (lastLength === undefined)
-                lastLength = text.length;
-            differentLength = lastLength !== text.length;
-        }
-
-        for (let i = 0; i < this._locations.length; i++) {
-            this._locations[i].timeLabel.x_align = differentLength
-                ? Clutter.ActorAlign.START
-                : Clutter.ActorAlign.END;
+            l.timeLabel.text = Util.formatTime(now, { timeOnly: true });
         }
     }